asdf2014 commented on a change in pull request #6633: make bitmap index usage
optional for bloom filters
URL: https://github.com/apache/incubator-druid/pull/6633#discussion_r234181403
##########
File path:
extensions-core/druid-bloom-filter/src/main/java/org/apache/druid/query/filter/BloomDimFilter.java
##########
@@ -174,14 +184,17 @@ public ExtractionFn getExtractionFn()
return extractionFn;
}
+
@Override
- public String toString()
+ public RangeSet<String> getDimensionRangeSet(String dimension)
{
- if (extractionFn != null) {
- return StringUtils.format("%s(%s) = %s", extractionFn, dimension,
hash.toString());
- } else {
- return StringUtils.format("%s = %s", dimension, hash.toString());
- }
+ return null;
Review comment:
It would be better if you could add the `@Nullable` annotation to this
method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
