leventov commented on a change in pull request #6662: Double-checked locking
bug is fixed.
URL: https://github.com/apache/incubator-druid/pull/6662#discussion_r236309526
##########
File path:
processing/src/main/java/org/apache/druid/query/filter/JavaScriptDimFilter.java
##########
@@ -115,18 +115,14 @@ public Filter toFilter()
* This class can be used by multiple threads, so this function should be
thread-safe to avoid extra
* script compilation.
*/
- private void checkAndCreatePredicateFactory()
+ private synchronized void checkAndCreatePredicateFactory()
{
+ // JavaScript configuration should be checked when it's actually used
because someone might still want Druid
+ // nodes to be able to deserialize JavaScript-based objects even though
JavaScript is disabled.
+ Preconditions.checkState(config.isEnabled(), "JavaScript is disabled");
+
if (predicateFactory == null) {
- // JavaScript configuration should be checked when it's actually used
because someone might still want Druid
- // nodes to be able to deserialize JavaScript-based objects even though
JavaScript is disabled.
- Preconditions.checkState(config.isEnabled(), "JavaScript is disabled");
-
- synchronized (config) {
- if (predicateFactory == null) {
- predicateFactory = new JavaScriptPredicateFactory(function,
extractionFn);
- }
- }
+ predicateFactory = new JavaScriptPredicateFactory(function,
extractionFn);
Review comment:
Please add `@Nullable` to `predicateFactory`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
