jsun98 commented on a change in pull request #6431: Add Kinesis Indexing
Service to core Druid
URL: https://github.com/apache/incubator-druid/pull/6431#discussion_r236912362
##########
File path:
extensions-core/kafka-indexing-service/src/main/java/org/apache/druid/indexing/kafka/IncrementalPublishingKafkaIndexTaskRunner.java
##########
@@ -1065,10 +142,20 @@ private void possiblyResetOffsetsOrWait(
final TopicPartition topicPartition = outOfRangePartition.getKey();
final long nextOffset = outOfRangePartition.getValue();
// seek to the beginning to get the least available offset
- consumer.seekToBeginning(Collections.singletonList(topicPartition));
- final long leastAvailableOffset = consumer.position(topicPartition);
+ StreamPartition<Integer> streamPartition = StreamPartition.of(
+ topicPartition.topic(),
+ topicPartition.partition()
+ );
+ recordSupplier.seekToEarliest(ImmutableSet.of(streamPartition));
Review comment:
the behavior of `getEarliestSequenceNumber` was changed to not have side
effects on the kafka conumer's position
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
