jihoonson commented on a change in pull request #6676: Handoff should ignore
segments that are dropped by drop rules
URL: https://github.com/apache/incubator-druid/pull/6676#discussion_r237217183
##########
File path:
server/src/main/java/org/apache/druid/segment/realtime/plumber/CoordinatorBasedSegmentHandoffNotifier.java
##########
@@ -95,6 +95,17 @@ void checkForSegmentHandoffs()
Map.Entry<SegmentDescriptor, Pair<Executor, Runnable>> entry =
itr.next();
SegmentDescriptor descriptor = entry.getKey();
try {
+ if (coordinatorClient.isSpecificIntervalDroppedByRule(dataSource,
descriptor.getInterval())) {
Review comment:
This will require more HTTP calls. I think it's better to use a single API
to check this and get the server view below.
That API should be able to notify caller that the handoff for the requested
segment will never happen.
We might improve the existing coordinator API,
`DataSourceResource.getSegmentDataSourceSpecificInterval()` or we can add a new
one for it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
