leventov commented on a change in pull request #6606: Simplify
DruidNodeDiscoveryProvider; add
DruidNodeDiscovery.Listener.nodeViewInitialized()
URL: https://github.com/apache/incubator-druid/pull/6606#discussion_r237561372
##########
File path:
server/src/main/java/org/apache/druid/discovery/DruidNodeDiscoveryProvider.java
##########
@@ -139,45 +150,39 @@ public void nodesAdded(List<DiscoveryDruidNode>
nodesDiscovered)
}
}
- ImmutableList<DiscoveryDruidNode> newNodesAdded = null;
- if (uninitializedNodeTypeListeners.isEmpty()) {
- newNodesAdded = builder.build();
- } else if (uninitializedNodeTypeListeners.remove(this) &&
uninitializedNodeTypeListeners.isEmpty()) {
Review comment:
I don't understand your question. Could you suggest what Javadoc comment you
think should be added and where?
Note: it shouldn't explain anything about the "old version", because that
code won't exist anymore.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
