jihoonson opened a new pull request #6686: Fix overlord api
URL: https://github.com/apache/incubator-druid/pull/6686
 
 
   Fixes https://github.com/apache/incubator-druid/issues/6684.
   
   There're two APIs causing the error of 
"org.apache.druid.java.util.common.ISE: Request did not have an authorization 
check performed", i.e., `/task/{dataSource}/shutdownAllTasks` and 
`/dataSources/{dataSource}`. 
   
   For `/task/{dataSource}/shutdownAllTasks`, I fixed the bug and changed the 
path to `/datasources/{dataSource}/shutdownAllTasks` since I think it makes 
more sense.
   
   For `/dataSources/{dataSource}`, I removed it because the new `/tasks` API 
can do the same thing. This API was added in 
https://github.com/apache/incubator-druid/pull/5260 which is tagged 0.13.0, so 
I think it's fine to remove it.
   
   To test overlord APIs, I fixed `OverlordResourceTest` to do some real tests. 
But, authorization check by annotated `ResourceFilter` is not easy, so I 
commented out them in the test and opened 
https://github.com/apache/incubator-druid/issues/6685.
   
   I also fixed the `kill` button of overlord console.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to