mkuthan commented on a change in pull request #6493: Support for request
logging in kafka emitter.
URL: https://github.com/apache/incubator-druid/pull/6493#discussion_r239110957
##########
File path:
extensions-contrib/kafka-emitter/src/main/java/org/apache/druid/emitter/kafka/KafkaEmitter.java
##########
@@ -156,14 +174,16 @@ private void sendToKafka(final String topic,
MemoryBoundLinkedBlockingQueue<Stri
public void emit(final Event event)
{
if (event != null) {
- ImmutableMap.Builder<String, Object> resultBuilder =
ImmutableMap.<String, Object>builder().putAll(event.toMap());
Review comment:
+1 for annotation based Jackson serialization instead of toMap but how to
inject additional clusterName field? What if is specific event defines
clusterName field internally, it should be overwritten by kafka emitter or not?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
