clintropolis commented on a change in pull request #6713: Fix travis timeout in
BufferHashGrouperTest
URL: https://github.com/apache/incubator-druid/pull/6713#discussion_r239299374
##########
File path:
processing/src/test/java/org/apache/druid/query/groupby/epinephelinae/BufferHashGrouperTest.java
##########
@@ -140,8 +140,8 @@ public void testGrowing()
public void testGrowing2()
{
final TestColumnSelectorFactory columnSelectorFactory =
GrouperTestUtil.newColumnSelectorFactory();
- final Grouper<Integer> grouper = makeGrouper(columnSelectorFactory,
2_000_000_000, 2);
- final int expectedMaxSize = NullHandling.replaceWithDefault() ? 40988516 :
39141224;
+ final Grouper<Integer> grouper = makeGrouper(columnSelectorFactory,
250_000_000, 2);
Review comment:
Should you add a comment to explain why this value is significant? Also if
you're feeling ambitious, maybe would be nice to rename tests to something like
`testGrowingOverflow` since that is what I think this is testing, and maybe
`testGrowingMax` for `testGrowing3`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
