jihoonson commented on issue #6713: Fix travis timeout in BufferHashGrouperTest URL: https://github.com/apache/incubator-druid/pull/6713#issuecomment-444723033 It looks that `testGrowing3` still makes the test fail, so I removed it. Also, the `bufferSize` of the previous change wasn't good to test the bug case reported in #4333, so I adjusted it and `maxLoadFactor` again. You can verify that `testGrowingOverflowingInteger()` still checks the bug of #4333 by adding the below code to `ByteBufferHashTable.adjustTableWhenFull()`. It's working if it prints `different !!!!!!!!`. ``` final boolean a = ((long) maxBuckets * 3 * bucketSizeWithHash + tableStart) > (long) tableArenaSize; final boolean b = (maxBuckets * 3 * bucketSizeWithHash + tableStart) > tableArenaSize; if (a != b) { System.err.println("different !!!!!!!!"); } else { System.out.println("same"); } ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
