clintropolis commented on a change in pull request #6638: Fixed buckets histogram aggregator URL: https://github.com/apache/incubator-druid/pull/6638#discussion_r240918351
########## File path: processing/src/main/java/org/apache/druid/segment/serde/ComplexMetricExtractor.java ########## @@ -33,4 +34,10 @@ @Nullable T extractValue(InputRow inputRow, String metricName); + + @Nullable + default T extractValue(InputRow inputRow, String metricName, AggregatorFactory agg) Review comment: Hmm, I definitely see the need for flexibility of being able to control complex metric extraction on a per `AggregatorFactory` basis in order to make use of indexing job specific context, but is this the best way to plumb this? I don't know and just wanted to discuss this part since it's an `@ExtensionPoint`, and need to look at it a bit closer myself. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
