jihoonson commented on a change in pull request #6431: Add Kinesis Indexing
Service to core Druid
URL: https://github.com/apache/incubator-druid/pull/6431#discussion_r241629745
##########
File path:
extensions-core/kafka-indexing-service/src/main/java/org/apache/druid/indexing/kafka/KafkaTuningConfig.java
##########
@@ -21,49 +21,22 @@
import com.fasterxml.jackson.annotation.JsonCreator;
import com.fasterxml.jackson.annotation.JsonProperty;
+import org.apache.druid.indexing.seekablestream.SeekableStreamTuningConfig;
import org.apache.druid.segment.IndexSpec;
-import org.apache.druid.segment.indexing.RealtimeTuningConfig;
-import org.apache.druid.segment.indexing.TuningConfig;
-import org.apache.druid.segment.realtime.appenderator.AppenderatorConfig;
import org.apache.druid.segment.writeout.SegmentWriteOutMediumFactory;
import org.joda.time.Period;
import javax.annotation.Nullable;
import java.io.File;
-import java.util.Objects;
-public class KafkaTuningConfig implements TuningConfig, AppenderatorConfig
+public class KafkaTuningConfig extends SeekableStreamTuningConfig
{
- private static final int DEFAULT_MAX_ROWS_PER_SEGMENT = 5_000_000;
- private static final boolean DEFAULT_RESET_OFFSET_AUTOMATICALLY = false;
-
- private final int maxRowsInMemory;
- private final long maxBytesInMemory;
- private final int maxRowsPerSegment;
- @Nullable
- private final Long maxTotalRows;
- private final Period intermediatePersistPeriod;
- private final File basePersistDirectory;
- @Deprecated
- private final int maxPendingPersists;
- private final IndexSpec indexSpec;
- private final boolean reportParseExceptions;
- private final long handoffConditionTimeout;
- private final boolean resetOffsetAutomatically;
- @Nullable
- private final SegmentWriteOutMediumFactory segmentWriteOutMediumFactory;
- private final Period intermediateHandoffPeriod;
-
- private final boolean logParseExceptions;
- private final int maxParseExceptions;
- private final int maxSavedParseExceptions;
-
@JsonCreator
public KafkaTuningConfig(
@JsonProperty("maxRowsInMemory") @Nullable Integer maxRowsInMemory,
@JsonProperty("maxBytesInMemory") @Nullable Long maxBytesInMemory,
@JsonProperty("maxRowsPerSegment") @Nullable Integer maxRowsPerSegment,
- @JsonProperty("maxTotalRows") @Nullable Long maxTotalRows,
+ @JsonProperty("maxTotalRows") Long maxTotalRows,
Review comment:
This is still nullable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
