jsun98 commented on a change in pull request #6431: Add Kinesis Indexing
Service to core Druid
URL: https://github.com/apache/incubator-druid/pull/6431#discussion_r241907740
##########
File path:
extensions-core/kafka-indexing-service/src/main/java/org/apache/druid/indexing/kafka/KafkaTuningConfig.java
##########
@@ -288,76 +76,74 @@ public KafkaTuningConfig withBasePersistDirectory(File
dir)
}
@Override
- public boolean equals(Object o)
+ public KafkaTuningConfig copyOf()
{
- if (this == o) {
- return true;
- }
- if (o == null || getClass() != o.getClass()) {
- return false;
- }
- KafkaTuningConfig that = (KafkaTuningConfig) o;
- return maxRowsInMemory == that.maxRowsInMemory &&
- maxRowsPerSegment == that.maxRowsPerSegment &&
- maxBytesInMemory == that.maxBytesInMemory &&
- Objects.equals(maxTotalRows, that.maxTotalRows) &&
- maxPendingPersists == that.maxPendingPersists &&
- reportParseExceptions == that.reportParseExceptions &&
- handoffConditionTimeout == that.handoffConditionTimeout &&
- resetOffsetAutomatically == that.resetOffsetAutomatically &&
- Objects.equals(intermediatePersistPeriod,
that.intermediatePersistPeriod) &&
- Objects.equals(basePersistDirectory, that.basePersistDirectory) &&
- Objects.equals(indexSpec, that.indexSpec) &&
- Objects.equals(segmentWriteOutMediumFactory,
that.segmentWriteOutMediumFactory) &&
- Objects.equals(intermediateHandoffPeriod,
that.intermediateHandoffPeriod) &&
- logParseExceptions == that.logParseExceptions &&
- maxParseExceptions == that.maxParseExceptions &&
- maxSavedParseExceptions == that.maxSavedParseExceptions;
+ return new KafkaTuningConfig(
+ getMaxRowsInMemory(),
+ getMaxBytesInMemory(),
+ getMaxRowsPerSegment(),
+ getMaxTotalRows(),
+ getIntermediatePersistPeriod(),
+ getBasePersistDirectory(),
+ 0,
Review comment:
`maxPendingPersists` is being deprecated, in the constructor of the original
`KafkaTuningConfig` it is always set to 0
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
