jihoonson commented on a change in pull request #6431: Add Kinesis Indexing
Service to core Druid
URL: https://github.com/apache/incubator-druid/pull/6431#discussion_r242343928
##########
File path:
extensions-core/kafka-indexing-service/src/main/java/org/apache/druid/indexing/kafka/supervisor/KafkaSupervisorTuningConfig.java
##########
@@ -159,8 +174,27 @@ public String toString()
'}';
}
- private static Duration defaultDuration(final Period period, final String
theDefault)
+ @Override
+ public SeekableStreamIndexTaskTuningConfig convertToTaskTuningConfig()
{
- return (period == null ? new Period(theDefault) :
period).toStandardDuration();
+ return new KafkaIndexTaskTuningConfig(
+ getMaxRowsInMemory(),
+ getMaxBytesInMemory(),
+ getMaxRowsPerSegment(),
+ getMaxTotalRows(),
+ getIntermediatePersistPeriod(),
+ getBasePersistDirectory(),
+ 0,
Review comment:
This is still 0 here and in `toString`. Please fix
`KinesisSupervisorTuningConfig` as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
