clintropolis commented on a change in pull request #6745: add version
comparator for StringComparator
URL: https://github.com/apache/incubator-druid/pull/6745#discussion_r242730994
##########
File path:
processing/src/test/java/org/apache/druid/query/ordering/StringComparatorsTest.java
##########
@@ -142,6 +142,16 @@ public void testNumericComparator()
Assert.assertTrue(StringComparators.NUMERIC.compare("CAN'T PARSE THIS",
"CAN'T TOUCH THIS") < 0);
}
+ @Test
+ public void testVersionComparator()
Review comment:
All of these tests also pass with `alphanumeric` sorting, maybe worth adding
some test cases from the upstream project
https://github.com/apache/maven/blob/a2b800de32cdb9adc1e64a43a0fc32e3ba878103/maven-artifact/src/test/java/org/apache/maven/artifact/versioning/DefaultArtifactVersionTest.java
to illustrate the need for this comparator.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
