jsun98 commented on a change in pull request #6431: Add Kinesis Indexing
Service to core Druid
URL: https://github.com/apache/incubator-druid/pull/6431#discussion_r242738128
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/TaskReportData.java
##########
@@ -117,4 +117,9 @@ public String toString()
(lag != null ? ", lag=" + lag : "") +
'}';
}
+
+ public enum TaskType
Review comment:
seems like `TaskType` is used by the supervisor to report tasks that are in
`activelyReadingTaskGroups` which are ACTIVE or `pendingCompletionTaskGroups`
which are PUBLISHING. I guess the supervisor doesn't know whether the task is
in NOT_STARTED, STARTING, or READING, so it considers all of them ACTIVE, do
you think we should use SeekableStreamIndexTaskRunner.Status instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
