dyf6372 commented on a change in pull request #6745: add version comparator for 
StringComparator
URL: https://github.com/apache/incubator-druid/pull/6745#discussion_r242779286
 
 

 ##########
 File path: 
processing/src/test/java/org/apache/druid/query/ordering/StringComparatorsTest.java
 ##########
 @@ -142,6 +142,16 @@ public void testNumericComparator()
     Assert.assertTrue(StringComparators.NUMERIC.compare("CAN'T PARSE THIS", 
"CAN'T TOUCH THIS") < 0);
   }
 
+  @Test
+  public void testVersionComparator()
 
 Review comment:
   Thanks, I'll add more test cases.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to