gianm commented on a change in pull request #6757: Set is_available to false by
default for published segment
URL: https://github.com/apache/incubator-druid/pull/6757#discussion_r243356828
##########
File path:
sql/src/test/java/org/apache/druid/sql/calcite/schema/SystemSchemaTest.java
##########
@@ -330,10 +330,10 @@ public void testGetTableMap()
public void testSegmentsTable() throws Exception
{
// total segments = 6
- // segments 1,2,3 are published and available
- // segments 4,5,6 are published but unavailable
- // segment 3 is published but not served
- // segment 2 is served by 2 servers, so num_replicas=2
+ // segments 1,2,3 are published but unavailable
+ // segments 4,5,6 are published and available
Review comment:
Thanks. Part of the goal of system tables is to help people diagnose issues
when things don't quite "add up". So it's important that the fields mean what
they are supposed to, rather than inferring them from other things (since those
inferences might be invalid if the system is in a funky state).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
