asdf2014 commented on a change in pull request #6767: Fix auto compaction to
consider intervals of running tasks
URL: https://github.com/apache/incubator-druid/pull/6767#discussion_r243871763
##########
File path:
server/src/main/java/org/apache/druid/server/coordinator/helper/DruidCoordinatorSegmentCompactor.java
##########
@@ -77,23 +83,45 @@ public DruidCoordinatorRuntimeParams
run(DruidCoordinatorRuntimeParams params)
Map<String, DataSourceCompactionConfig> compactionConfigs =
compactionConfigList
.stream()
.collect(Collectors.toMap(DataSourceCompactionConfig::getDataSource,
Function.identity()));
- final int numNonCompleteCompactionTasks =
findNumNonCompleteCompactTasks(
+ final List<TaskStatusPlus> compactTasks = filterNonCompactTasks(
indexingServiceClient.getRunningTasks(),
indexingServiceClient.getPendingTasks(),
indexingServiceClient.getWaitingTasks()
);
- final CompactionSegmentIterator iterator =
policy.reset(compactionConfigs, dataSources);
+ final Map<String, List<Interval>> compactTaskIntervals = new
HashMap<>();
Review comment:
Maybe `new HashMap<>(compactTasks.size())` would be better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
