QiuMM edited a comment on issue #6336: update insert pending segments logic to 
synchronous
URL: https://github.com/apache/incubator-druid/pull/6336#issuecomment-450683860
 
 
   >  there should be no lock contention between tasks unless they are replica 
tasks
   
   @jihoonson not only replica tasks, all tasks create by a supervisor would 
share same `TaskLock#groupId`, and in my scenario there are at most 600 tasks 
for a datasource.  So still many tasks share the same lock.
   
   > Since the taskLock must be acquired before calling 
allocatePendingSegmentAction in doInSyncDataSourceAndInterval, I don't think 
this exception is related to the granular locking.
   
   I'm not very sure about this, but I have also observed such exception even 
if I didn't use `doInSyncDataSourceAndInterval`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to