jihoonson commented on a change in pull request #6629: Add support parallel
combine in brokers
URL: https://github.com/apache/incubator-druid/pull/6629#discussion_r244827002
##########
File path: core/src/main/java/org/apache/druid/collections/BlockingPool.java
##########
@@ -24,8 +24,21 @@
public interface BlockingPool<T>
{
+ /**
+ * Returns the total pool size.
+ */
int maxSize();
+ /**
+ * Returns the number of current available resources.
+ */
+ int available();
+
+ /**
+ * Poll all available resources from the pool. If there's no available
resource, it returns an empty list.
Review comment:
I don't think this is a subset of BlockingQueue. It's only similar in terms
of "the blocking operation", but it doesn't mean they're similar. The queue and
the pool are different. The key characteristic of the queue is that it's FIFO,
but there's no order for inserting/getting items to/from the pool.
I don't think anyone would guess BlockingPool's behavior by comparing it
with BlockingQueue. If something is not clear, it just means we need to add
more detailed doc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
