jon-wei commented on a change in pull request #6638: Fixed buckets histogram aggregator URL: https://github.com/apache/incubator-druid/pull/6638#discussion_r244889840
########## File path: extensions-core/histogram/src/main/java/org/apache/druid/query/aggregation/histogram/FixedBucketsHistogramSerde.java ########## @@ -0,0 +1,190 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.query.aggregation.histogram; + +import com.google.common.collect.Ordering; +import org.apache.druid.common.config.NullHandling; +import org.apache.druid.data.input.InputRow; +import org.apache.druid.data.input.Rows; +import org.apache.druid.java.util.common.logger.Logger; +import org.apache.druid.java.util.common.parsers.ParseException; +import org.apache.druid.query.aggregation.AggregatorFactory; +import org.apache.druid.segment.GenericColumnSerializer; +import org.apache.druid.segment.column.ColumnBuilder; +import org.apache.druid.segment.data.GenericIndexed; +import org.apache.druid.segment.data.ObjectStrategy; +import org.apache.druid.segment.serde.ComplexColumnPartSupplier; +import org.apache.druid.segment.serde.ComplexMetricExtractor; +import org.apache.druid.segment.serde.ComplexMetricSerde; +import org.apache.druid.segment.serde.LargeColumnSupportedComplexColumnSerializer; +import org.apache.druid.segment.writeout.SegmentWriteOutMedium; + +import javax.annotation.Nullable; +import java.nio.ByteBuffer; + +public class FixedBucketsHistogramSerde extends ComplexMetricSerde +{ + private static final Logger LOG = new Logger(FixedBucketsHistogramSerde.class); + + private static Ordering<FixedBucketsHistogram> comparator = new Ordering<FixedBucketsHistogram>() + { + @Override + public int compare( + FixedBucketsHistogram arg1, + FixedBucketsHistogram arg2 + ) + { + return FixedBucketsHistogramAggregator.COMPARATOR.compare(arg1, arg2); + } + }.nullsFirst(); + + @Override + public String getTypeName() + { + return FixedBucketsHistogramAggregator.TYPE_NAME; + } + + @Override + public ComplexMetricExtractor getExtractor() + { + return new ComplexMetricExtractor() + { + @Override + public Class<FixedBucketsHistogram> extractedClass() + { + return FixedBucketsHistogram.class; + } + + @Nullable + @Override + public Object extractValue(InputRow inputRow, String metricName) + { + throw new UnsupportedOperationException("extractValue without an aggregator factory is not supported."); + } + + @Override + public FixedBucketsHistogram extractValue(InputRow inputRow, String metricName, AggregatorFactory agg) + { + Object rawValue = inputRow.getRaw(metricName); + + FixedBucketsHistogramAggregatorFactory aggregatorFactory = (FixedBucketsHistogramAggregatorFactory) agg; + + if (rawValue == null) { + //throw new UnsupportedOperationException("Null not supported yet."); Review comment: Removed ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
