gianm commented on a change in pull request #6800: Copy splitToList from Guava
URL: https://github.com/apache/incubator-druid/pull/6800#discussion_r244903900
##########
File path:
core/src/main/java/org/apache/druid/java/util/common/parsers/DelimitedParser.java
##########
@@ -74,6 +77,24 @@ public DelimitedParser(
@Override
protected List<String> parseLine(String input)
{
- return splitter.splitToList(input);
+ return splitToList(input);
+ }
+
+ /**
+ * Copied from Guava's {@link Splitter#splitToList(CharSequence)}.
+ * This is to avoid the missing method signature error when using an old
Guava library.
Review comment:
Could you write some more comments, or link to an issue, describing what
situations this helps in?
Something like: this may happen when running Druid Hadoop indexing jobs,
since we may inherit the version provided by the Hadoop cluster.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
