JasonChoi27 closed pull request #6778: Add RollingFile policy to log4j2
URL: https://github.com/apache/incubator-druid/pull/6778
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/examples/conf/druid/_common/log4j2.xml
b/examples/conf/druid/_common/log4j2.xml
index 0e0f02f2ca6..6ac9993b4aa 100644
--- a/examples/conf/druid/_common/log4j2.xml
+++ b/examples/conf/druid/_common/log4j2.xml
@@ -17,16 +17,33 @@
~ specific language governing permissions and limitations
~ under the License.
-->
-
<Configuration status="WARN">
- <Appenders>
- <Console name="Console" target="SYSTEM_OUT">
- <PatternLayout pattern="%d{ISO8601} %p [%t] %c - %m%n"/>
- </Console>
- </Appenders>
- <Loggers>
- <Root level="info">
- <AppenderRef ref="Console"/>
- </Root>
- </Loggers>
+<Properties>
+ <property name="base_path">log</property>
+ <property name="rolling_max">50</property>
+ <property name="every_file_size">256MB</property>
+</Properties>
+
+<Appenders>
+ <Console name="Console" target="SYSTEM_OUT">
+ <PatternLayout pattern="%d{ISO8601} %p [%t] %c - %m%n"/>
+ </Console>
+
+ <RollingFile name="RollingFile"
fileName="${base_path}/${sys:log.path.prefix}.log"
+
filePattern="${base_path}/%d{yyyy-MM}/${sys:log.path.prefix}-%d{yyyy-MM-dd}-%i.log.gz">
+ <PatternLayout>
+ <Pattern>%d{ISO8601} %p [%t] %c - %m%n</Pattern>
+ </PatternLayout>
+ <Policies>
+ <TimeBasedTriggeringPolicy interval="1"/>
+ <SizeBasedTriggeringPolicy size="${every_file_size}"/>
+ </Policies>
+ <DefaultRolloverStrategy max="${rolling_max}"/>
+ </RollingFile>
+</Appenders>
+<Loggers>
+ <Root level="info">
+ <AppenderRef ref="${sys:log.appender.ref}"/>
+ </Root>
+</Loggers>
</Configuration>
diff --git a/examples/conf/druid/broker/jvm.config
b/examples/conf/druid/broker/jvm.config
index a6a9982d44c..9720b04b8aa 100644
--- a/examples/conf/druid/broker/jvm.config
+++ b/examples/conf/druid/broker/jvm.config
@@ -6,3 +6,5 @@
-Dfile.encoding=UTF-8
-Djava.io.tmpdir=var/tmp
-Djava.util.logging.manager=org.apache.logging.log4j.jul.LogManager
+-Dlog.appender.ref=Console
+-Dlog.path.prefix=broker
diff --git a/examples/conf/druid/coordinator/jvm.config
b/examples/conf/druid/coordinator/jvm.config
index 99f6d1d646f..88771e31a84 100644
--- a/examples/conf/druid/coordinator/jvm.config
+++ b/examples/conf/druid/coordinator/jvm.config
@@ -6,3 +6,5 @@
-Djava.io.tmpdir=var/tmp
-Djava.util.logging.manager=org.apache.logging.log4j.jul.LogManager
-Dderby.stream.error.file=var/druid/derby.log
+-Dlog.appender.ref=Console
+-Dlog.path.prefix=coordinator
diff --git a/examples/conf/druid/historical/jvm.config
b/examples/conf/druid/historical/jvm.config
index 7fdbb1c51ce..afb76076058 100644
--- a/examples/conf/druid/historical/jvm.config
+++ b/examples/conf/druid/historical/jvm.config
@@ -6,3 +6,5 @@
-Dfile.encoding=UTF-8
-Djava.io.tmpdir=var/tmp
-Djava.util.logging.manager=org.apache.logging.log4j.jul.LogManager
+-Dlog.appender.ref=Console
+-Dlog.path.prefix=historical
diff --git a/examples/conf/druid/middleManager/jvm.config
b/examples/conf/druid/middleManager/jvm.config
index 7b9f1a47b55..74dfdb834e4 100644
--- a/examples/conf/druid/middleManager/jvm.config
+++ b/examples/conf/druid/middleManager/jvm.config
@@ -5,3 +5,5 @@
-Dfile.encoding=UTF-8
-Djava.io.tmpdir=var/tmp
-Djava.util.logging.manager=org.apache.logging.log4j.jul.LogManager
+-Dlog.appender.ref=Console
+-Dlog.path.prefix=middleManager
diff --git a/examples/conf/druid/middleManager/runtime.properties
b/examples/conf/druid/middleManager/runtime.properties
index 8fb56821ecd..f5a6e23fb87 100644
--- a/examples/conf/druid/middleManager/runtime.properties
+++ b/examples/conf/druid/middleManager/runtime.properties
@@ -33,6 +33,7 @@ druid.server.http.numThreads=25
# Processing threads and buffers on Peons
druid.indexer.fork.property.druid.processing.buffer.sizeBytes=536870912
druid.indexer.fork.property.druid.processing.numThreads=2
+druid.indexer.fork.property.log.appender.ref=Console
# Hadoop indexing
druid.indexer.task.hadoopWorkingPath=var/druid/hadoop-tmp
diff --git a/examples/conf/druid/overlord/jvm.config
b/examples/conf/druid/overlord/jvm.config
index 2df9a1c2d53..15b54634c4b 100644
--- a/examples/conf/druid/overlord/jvm.config
+++ b/examples/conf/druid/overlord/jvm.config
@@ -5,3 +5,5 @@
-Dfile.encoding=UTF-8
-Djava.io.tmpdir=var/tmp
-Djava.util.logging.manager=org.apache.logging.log4j.jul.LogManager
+-Dlog.appender.ref=Console
+-Dlog.path.prefix=overlord
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
