leventov commented on issue #6370: Introduce SegmentId class URL: https://github.com/apache/incubator-druid/pull/6370#issuecomment-452682953 After writing the previous comment, I realized that `SegmentDescriptor` should be more properly compared with `SegmentId` rather than with `DataSegment`, it would be more apples-to-apples comparison. I updated the relevant comments to the following: > The difference between this class and `{@link org.apache.druid.query.SegmentDescriptor}` is that the latter is a "light" version of SegmentId, that only contains the interval, version, and partition number. It's used where the data source, another essential part of SegmentId is determined by the context (e. g. in `{@link org.apache.druid.client.CachingClusteredClient}`, where SegmentDescriptor is used when Brokers tell data servers which segments to include for a particular query) and where having lean JSON representations is important, because it's actively transferred detween Druid nodes. It's also for this reason that the JSON field names of SegmentDescriptor are abbreviated.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
