gianm commented on issue #6866: Reverse dependencies from /main/ to /test/ URL: https://github.com/apache/incubator-druid/issues/6866#issuecomment-454657143 > Having main depending on test creates unnecessary errors, at least in Eclipse, I don't know how this is solved in IntelliJ. And to fix those errors I have to manually copy and add the test jars into the build path, which is a PITA. I don't think it is reasonable to expect all developers who wish to contribute to Druid to use IntelliJ. I not only have a huge history of projects in Eclipse, but I use it for C/C++, Ocaml, and other languages as well. IntelliJ doesn't seem to care. Contributions that help make things work better in Eclipse would definitely be welcome. > In our DataSketches library we created a separate characterization repository, which is for long-running benchmarking tests and studies. This makes the core repository clean. If benchmarks is not actually distributed, might this work for Druid? IMO keeping it all part of the same repo is a good thing, for a few reasons: 1. New benchmarks verifying the efficacy of a patch can be entered in the same PR as the patch itself. 2. Benchmarks use a lot of internal APIs, which are often adjusted for various reasons, and keeping the benchmarks in the main repo means they get adjusted together in the same commit. 3. Having all the Druid code together in one repo makes it easier for new contributors to get up and running.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
