leventov commented on a change in pull request #6804: Fix num_replicas count in sys.segments table URL: https://github.com/apache/incubator-druid/pull/6804#discussion_r248612367
########## File path: sql/src/main/java/org/apache/druid/sql/calcite/schema/SegmentMetadataHolder.java ########## @@ -36,7 +38,8 @@ private final long isAvailable; private final long isRealtime; private final String segmentId; - private final long numReplicas; + //segmentId -> set of servers that contain the segment + private final Map<String, Set<String>> segmentServerMap; Review comment: Won't `lhs` in that Pair always be equal to `segmentId` field? In other words shouldn't it be just `Set<String> servers` field? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
