leventov commented on a change in pull request #6370: Introduce SegmentId class
URL: https://github.com/apache/incubator-druid/pull/6370#discussion_r249020631
 
 

 ##########
 File path: core/src/main/java/org/apache/druid/timeline/DataSegment.java
 ##########
 @@ -271,15 +244,16 @@ public long getSize()
     return size;
   }
 
-  @JsonProperty
-  public String getIdentifier()
+  // "identifier" for backward compatibility of JSON API
+  @JsonProperty(value = "identifier", access = JsonProperty.Access.READ_ONLY)
+  public SegmentId getId()
 
 Review comment:
   #6885

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to