leventov opened a new issue #6909: Remove CardinalityAggregatorColumnSelectorStrategy and CardinalityAggregatorColumnSelectorStrategyFactory as too shallow abstractions. URL: https://github.com/apache/incubator-druid/issues/6909 The logic of `CardinalityAggregatorColumnSelectorStrategyFactory` could be inlined in `CardinalityAggregatorFactory.factorize()` and `factorizeBuffered()` methods, and the logic of `CardinalityAggregatorColumnSelectorStrategy` could be expressed in subclasses of `CardinalityBufferAggregator` and `CardinalityAggregator`. This change is similar to what is proposed here: https://github.com/apache/incubator-druid/pull/6397#discussion_r250564034
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
