clintropolis commented on a change in pull request #6883: Deprecate
NoneShardSpec
URL: https://github.com/apache/incubator-druid/pull/6883#discussion_r250817512
##########
File path: core/src/main/java/org/apache/druid/timeline/DataSegment.java
##########
@@ -373,7 +373,7 @@ public Builder()
this.loadSpec = ImmutableMap.of();
this.dimensions = ImmutableList.of();
this.metrics = ImmutableList.of();
- this.shardSpec = NoneShardSpec.instance();
+ this.shardSpec = new NumberedShardSpec(0, 1);
Review comment:
continuing other comment chain, alternatively maybe this line isn't
necessary if everything should be setting it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
