clintropolis commented on a change in pull request #6397: Adds bloom filter aggregator to 'druid-bloom-filters' extension URL: https://github.com/apache/incubator-druid/pull/6397#discussion_r251124280
########## File path: extensions-core/druid-bloom-filter/src/main/java/org/apache/druid/query/aggregation/bloom/BloomFilterAggregatorFactory.java ########## @@ -0,0 +1,296 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.query.aggregation.bloom; + +import com.fasterxml.jackson.annotation.JsonCreator; +import com.fasterxml.jackson.annotation.JsonProperty; +import org.apache.commons.codec.binary.Base64; +import org.apache.druid.guice.BloomFilterSerializersModule; +import org.apache.druid.java.util.common.IAE; +import org.apache.druid.java.util.common.RE; +import org.apache.druid.java.util.common.StringUtils; +import org.apache.druid.query.aggregation.Aggregator; +import org.apache.druid.query.aggregation.AggregatorFactory; +import org.apache.druid.query.aggregation.AggregatorUtil; +import org.apache.druid.query.aggregation.BufferAggregator; +import org.apache.druid.query.cache.CacheKeyBuilder; +import org.apache.druid.query.dimension.DimensionSpec; +import org.apache.druid.query.filter.BloomKFilter; +import org.apache.druid.segment.BaseNullableColumnValueSelector; +import org.apache.druid.segment.ColumnSelectorFactory; +import org.apache.druid.segment.NilColumnValueSelector; +import org.apache.druid.segment.column.ColumnCapabilities; +import org.apache.druid.segment.column.ValueType; + +import javax.annotation.Nullable; +import java.io.IOException; +import java.nio.ByteBuffer; +import java.util.Collections; +import java.util.Comparator; +import java.util.List; +import java.util.Objects; + +public class BloomFilterAggregatorFactory extends AggregatorFactory +{ + private static final int DEFAULT_NUM_ENTRIES = 1500; + + private static final Comparator COMPARATOR = Comparator.nullsFirst((o1, o2) -> { + if (o1 instanceof ByteBuffer && o2 instanceof ByteBuffer) { + ByteBuffer buf1 = (ByteBuffer) o1; + ByteBuffer buf2 = (ByteBuffer) o2; + return Integer.compare( + BloomKFilter.getNumSetBits(buf1, buf1.position()), + BloomKFilter.getNumSetBits(buf2, buf2.position()) + ); + } else if (o1 instanceof BloomKFilter && o2 instanceof BloomKFilter) { + BloomKFilter o1f = (BloomKFilter) o1; + BloomKFilter o2f = (BloomKFilter) o2; + return Integer.compare(o1f.getNumSetBits(), o2f.getNumSetBits()); + } else { + throw new RE("Unable to compare unexpected types [%s]", o1.getClass().getName()); + } + }); + + private final String name; + private final DimensionSpec field; + private final int maxNumEntries; + + @JsonCreator + public BloomFilterAggregatorFactory( + @JsonProperty("name") String name, + @JsonProperty("field") final DimensionSpec field, + @Nullable @JsonProperty("maxNumEntries") Integer maxNumEntries + ) + { + this.name = name; + this.field = field; + this.maxNumEntries = maxNumEntries != null ? maxNumEntries : DEFAULT_NUM_ENTRIES; + } + + @Override + public Aggregator factorize(ColumnSelectorFactory columnFactory) + { + BloomKFilter filter = new BloomKFilter(maxNumEntries); + ColumnCapabilities capabilities = columnFactory.getColumnCapabilities(field.getDimension()); + + if (capabilities == null) { + BaseNullableColumnValueSelector selector = columnFactory.makeColumnValueSelector(field.getDimension()); + if (selector instanceof NilColumnValueSelector) { + return new NilBloomFilterAggregator((NilColumnValueSelector) selector, filter); Review comment: :+1: agree, will change to "Empty" ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
