leventov commented on a change in pull request #6943: InterruptedExceptions
should never be ignored in the code.
URL: https://github.com/apache/incubator-druid/pull/6943#discussion_r251826638
##########
File path:
extensions-contrib/druid-rocketmq/src/main/java/org/apache/druid/firehose/rocketmq/RocketMQFirehoseFactory.java
##########
@@ -498,6 +502,7 @@ public void run()
}
catch (InterruptedException e) {
LOGGER.error(e, "");
+ Thread.currentThread().interrupt();
Review comment:
I think it's always better to put this statement first, before logging.
Because if an exception is thrown from logging the interruption status is
shallowed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
