clintropolis commented on a change in pull request #6951: Add more sketch
aggregator support in Druid SQL
URL: https://github.com/apache/incubator-druid/pull/6951#discussion_r252039199
##########
File path:
extensions-core/datasketches/src/main/java/org/apache/druid/query/aggregation/datasketches/hll/HllSketchModule.java
##########
@@ -57,6 +59,11 @@ public void configure(final Binder binder)
if (ComplexMetrics.getSerdeForType(MERGE_TYPE_NAME) == null) {
ComplexMetrics.registerSerde(MERGE_TYPE_NAME, new
HllSketchMergeComplexMetricSerde());
}
+
+ if (binder != null) {
Review comment:
It's possible to not need this if check by doing something like
[this](https://github.com/apache/incubator-druid/pull/6950/files#diff-dbabe3c8d0b963a928eac3cef360880bR99)
and using an injector
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
