surekhasaharan commented on a change in pull request #6901: Introduce published
segment cache in broker
URL: https://github.com/apache/incubator-druid/pull/6901#discussion_r252137440
##########
File path:
server/src/main/java/org/apache/druid/server/http/MetadataResource.java
##########
@@ -148,9 +151,25 @@ public Response
getDatabaseSegmentDataSource(@PathParam("dataSourceName") final
@GET
@Path("/segments")
@Produces(MediaType.APPLICATION_JSON)
- public Response getDatabaseSegments(@Context final HttpServletRequest req)
+ public Response getDatabaseSegments(
+ @Context final HttpServletRequest req,
+ @QueryParam("datasources") String datasources
Review comment:
Didn't find any existing API's taking in a list as query param in druid
code, so went with json string. Also the URL with list will look like
`/druid/coordinator/v1/metadata/segments?datasources="foo"&datasources="bar"&datasources="baz"`
instead of
`/druid/coordinator/v1/metadata/segments?datasources=["foo","bar","baz"]`. But
I can change if there's any benefit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
