jihoonson commented on issue #6690: bugfix: when building materialized-view, if taskCount>1, may cause concurrentModificationException URL: https://github.com/apache/incubator-druid/pull/6690#issuecomment-460393635 Oh I see. You’re right. Thanks. I think it would be better to first find the entries to be removed, and then remove then all at once after iteration. I think this is better than using ConcurrentMap because there’s no concurrency issue. What do you think? Also, all bug fix PRs should have unit tests. Would you please add one?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
