jihoonson commented on issue #6847: Curator server inventory await initialization URL: https://github.com/apache/incubator-druid/pull/6847#issuecomment-460854742 Thanks @QiuMM for raising this PR. I think the purpose of this PR makes sense and it would work as expected. However, the codes for waiting for serverView to be initialized are duplicated in `HttpServerInventoryView` and `CuratorInventoryManager`, and I think we can remove it. `CoordinatorServerView` has a baseView internally which can be either `HttpServerInventoryView` or `CuratorServerInventoryView`. Please note that `CuratorServerInventoryView` depends on `CuratorInventoryManager`. As a result, I think we can simply move the codes to wait for initialization from `HttpServerInventoryView` to `CoordinatorServerView`, so that the coordinator would wait for initialization regardless of the type of serverInventoryView. I think this is the aesthetical thing @gianm mentioned. What do you think?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
