jihoonson commented on issue #6989: Behavior of index_parallel with appendToExisting=false and no bucketIntervals in GranularitySpec is surprising URL: https://github.com/apache/incubator-druid/issues/6989#issuecomment-460878768 Thank you! Looking forward to your PR. I think it's safe to get locks dynamically. The indexTask already [gets locks one by one per interval](https://github.com/apache/incubator-druid/blob/master/indexing-service/src/main/java/org/apache/druid/indexing/common/task/Tasks.java#L55-L61) though it happens in a tight loop. Also, if there's something wrong in task locks, publishing segments must fail which makes tasks failed. Check out `SegmentTransactionalInsertAction` which is called in `SinglePhaseParallelIndexTaskRunner.publish()`.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
