leventov commented on issue #6858: Free AggregatorFactory implementors from boilerplate in getMergingFactory() URL: https://github.com/apache/incubator-druid/issues/6858#issuecomment-460938950 @hpandeycodeit I think it should have default implementation `return getClass();`. In AggregatorFactories that have subclasses, such as `ApproximateHistogramAggregatorFactory`, it should be overridden as ```java public final Class<...> getBaseMergeAggregatorFactoryClass() { return ApproximateHistogramAggregatorFactory.class; } ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
