jihoonson commented on a change in pull request #6888: Fix num_rows in
sys.segments
URL: https://github.com/apache/incubator-druid/pull/6888#discussion_r254509737
##########
File path:
sql/src/test/java/org/apache/druid/sql/calcite/schema/DruidSchemaTest.java
##########
@@ -239,6 +246,34 @@ public void testGetTableMapFoo2()
Assert.assertEquals(SqlTypeName.BIGINT,
fields.get(2).getType().getSqlTypeName());
}
+ @Test
+ public void testSegmentMetadataHolderNumRows()
Review comment:
Would you please add a comment about what this method is testing? It's not
intuitive from the code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
