clintropolis commented on a change in pull request #6971: Added checkstyle for
"Methods starting with Capital Letters"
URL: https://github.com/apache/incubator-druid/pull/6971#discussion_r255280736
##########
File path: sql/src/test/java/org/apache/druid/sql/calcite/CalciteQueryTest.java
##########
@@ -133,15 +133,15 @@ public void testSelectCountStart() throws Exception
CalciteTests.REGULAR_USER_AUTH_RESULT,
ImmutableList.of(Druids.newTimeseriesQueryBuilder()
.dataSource(CalciteTests.DATASOURCE1)
- .intervals(QSS(Filtration.eternity()))
- .filters(SELECTOR("dim2", "0", null))
+ .intervals(qss(Filtration.eternity()))
Review comment:
If you don't mind, please un-abbreviate the method names in the calcite
tests since you're making changes to all of these lines anyway might as well
make a better change, and switch them from snake_case to camelCase where
possible, e.g. `expresion_Post_Agg` (which also has a typo) to
`expressionPostAgg`.
Additionally, somehow the commit history on this PR has gotten very messed
up when you fixed conflicts (at least on github) and it's showing over 25k
added lines, making it basically impossible to review this PR anymore. I'm not
sure how it got into this state, but it might be better to cherry pick your
commits from this branch into another branch and open a new PR if you can't
find a way to fix it.
Also please don't mark review conversations as resolved, it makes it hard
for the reviewer to follow up on things.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
