egor-ryashin commented on a change in pull request #6794: Query vectorization. URL: https://github.com/apache/incubator-druid/pull/6794#discussion_r255358564
########## File path: processing/src/main/java/org/apache/druid/query/filter/vector/VectorValueMatcher.java ########## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.query.filter.vector; + +import org.apache.druid.segment.vector.VectorSizeInspector; + +/** + * A vectorized value matcher. + * + * @see org.apache.druid.query.filter.ValueMatcher, the non-vectorized version Review comment: ValueMatcher doesn't have a description and ValueMatcher list of implementation classes is quite big to understand its true role clearly, I think there should be a reference to a thorough description with a showcase code explaining (in general) the supposed way of interaction of ValueMatcher, Filter, Cursor and possibly other entities. And I think all other interfaces in that chain should also contain that reference link as most of them also have no description while having a huge list of implementations. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
