drcrallen commented on issue #7002: [Benchmarking] Call blackhole#consume() on collections instead of iterating through each element URL: https://github.com/apache/incubator-druid/pull/7002#issuecomment-462445824 The different usage mechanisms make this harder to track, but looking at `org.apache.druid.java.util.common.guava.Sequence#toList` (which is the underlying call in a bunch of places here) the only implementations are the eager accumulation into an array list. So this PR is probably safe as is. To protect against future development, can you please add a java doc to `org.apache.druid.java.util.common.guava.Sequence#toList` indicating that various benchmarks rely on this method to eagerly accumulate?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
