leventov commented on a change in pull request #6939: Throw caught exception.
URL: https://github.com/apache/incubator-druid/pull/6939#discussion_r255688148
##########
File path: codestyle/checkstyle.xml
##########
@@ -204,6 +204,12 @@
<property name="message" value="Use
org.apache.druid.server.http.HttpMediaType#TEXT_PLAIN_UTF8 instead"/>
</module>
+ <module name="Regexp">
+ <property name="format" value='^((?!throw|=).)* Throwables.propagate\('/>
+ <property name="illegalPattern" value="true"/>
+ <property name="message" value="Throw caught exception"/>
Review comment:
Thanks for doing this work.
I suggest to replace that particular `throw new RuntimeException(e)` that
leads to test breakage with
```java
Throwables.propagateIfPossible(e);
throw new RuntimeException(e);
```
Also please prohibit `Throwables.propagate()` in forbidden-apis.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
