justinborromeo commented on a change in pull request #7024: Time Ordering
Option on Small-Result-Set Scan Queries
URL: https://github.com/apache/incubator-druid/pull/7024#discussion_r257417414
##########
File path:
benchmarks/src/main/java/org/apache/druid/benchmark/query/ScanBenchmark.java
##########
@@ -107,12 +107,15 @@
@Param({"200000"})
private int rowsPerSegment;
- @Param({"basic.A"})
+ @Param({"basic.A", "basic.B", "basic.C", "basic.D"})
private String schemaAndQuery;
@Param({"1000", "99999"})
private int limit;
+ @Param({"none", "descending", "ascending"})
+ private static String timeOrdering;
Review comment:
The basicA(), basicB()... query builder functions are static (like in
SearchBenchmark). Since timeOrdering is used when building the query, it also
needs to be static.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
