clintropolis commented on a change in pull request #6902: sql, filters, and
virtual columns
URL: https://github.com/apache/incubator-druid/pull/6902#discussion_r258364440
##########
File path: sql/src/main/java/org/apache/druid/sql/calcite/rel/DruidQuery.java
##########
@@ -284,10 +310,11 @@ private static Grouping computeGrouping(
aggregate.getRowType()
);
+ DruidQuerySignature aggregateContext =
queryColumns.withRowSignature(aggregateRowSignature).asImmutable();
Review comment:
i'll add javadocs... the use is when additional virtual columns should not
be allowed to be defined, where the only current case of this is when
constructing a `having` filter.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
