This is an automated email from the ASF dual-hosted git repository.
gian pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-druid.git
The following commit(s) were added to refs/heads/master by this push:
new 9a52152 Since notify might not wake up the right thread, notifyAll
should be used instead. (#6931)
9a52152 is described below
commit 9a521526c7e15808ded5978abba40e1228eed784
Author: Furkan KAMACI <[email protected]>
AuthorDate: Wed Feb 20 20:02:58 2019 +0300
Since notify might not wake up the right thread, notifyAll should be used
instead. (#6931)
* Since notify might not wake up the right thread, notifyAll should be used
instead.
* Comment is added about why notifyAll() is not used.
---
.../java/org/apache/druid/firehose/rocketmq/RocketMQFirehoseFactory.java | 1 +
1 file changed, 1 insertion(+)
diff --git
a/extensions-contrib/druid-rocketmq/src/main/java/org/apache/druid/firehose/rocketmq/RocketMQFirehoseFactory.java
b/extensions-contrib/druid-rocketmq/src/main/java/org/apache/druid/firehose/rocketmq/RocketMQFirehoseFactory.java
index ce78180..377a98e 100644
---
a/extensions-contrib/druid-rocketmq/src/main/java/org/apache/druid/firehose/rocketmq/RocketMQFirehoseFactory.java
+++
b/extensions-contrib/druid-rocketmq/src/main/java/org/apache/druid/firehose/rocketmq/RocketMQFirehoseFactory.java
@@ -404,6 +404,7 @@ public class RocketMQFirehoseFactory implements
FirehoseFactory<InputRowParser<B
this.requestsWrite.add(request);
if (!hasNotified) {
hasNotified = true;
+ // No need to use notifyAll here since extended class
com.alibaba.rocketmq.common.ServiceThread handles it
notify();
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
