kfaraz commented on code in PR #17581:
URL: https://github.com/apache/druid/pull/17581#discussion_r1926310923
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/ParallelIndexSupervisorTask.java:
##########
@@ -1251,12 +1252,19 @@ private TaskStatus runSequential(TaskToolbox toolbox)
throws Exception
*/
private TaskReport.ReportMap getTaskCompletionReports(TaskStatus taskStatus)
{
- return buildIngestionStatsAndContextReport(
+ final TaskReport.ReportMap taskCompletionReport =
buildIngestionStatsAndContextReport(
IngestionState.COMPLETED,
taskStatus.getErrorMsg(),
segmentsRead,
segmentsPublished
);
+ final var totalProcessedBytes =
indexGenerateRowStats.lhs.get("processedBytes");
Review Comment:
Since we are going to cast this later in the code anyway, let's just do the
cast here and avoid the `var`.
```suggestion
final Number totalProcessedBytes = (Number)
indexGenerateRowStats.lhs.get("processedBytes");
```
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/ParallelIndexSupervisorTask.java:
##########
@@ -1251,12 +1252,19 @@ private TaskStatus runSequential(TaskToolbox toolbox)
throws Exception
*/
private TaskReport.ReportMap getTaskCompletionReports(TaskStatus taskStatus)
{
- return buildIngestionStatsAndContextReport(
Review Comment:
Nit: I think this line can remain exactly as it is (since we are not using
the task report in the computation). The logic to compute and emit the
processed bytes should just be before this line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
