clintropolis opened a new pull request, #17662: URL: https://github.com/apache/druid/pull/17662
### Description Fixes issue noticed in https://github.com/apache/druid/pull/16577#issuecomment-2611993686. The problem is that the search query was using `ColumnCapabilities.hasBitmapIndexes()` to check if it could use the indexes strategy, which used to be ok when there were only indexes on string columns and so every column with that set would also have a `DictionaryEncodedStringValueIndex`, but is no longer the case. To fix, the search query now explicitly checks for columns having a `DictionaryEncodedStringValueIndex` available since that is what the 'use indexes' strategy requires. The added test fails without the code changes in this PR. <hr> This PR has: - [x] been self-reviewed. - [x] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader. - [x] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met. - [x] been tested in a test Druid cluster. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
