ashwintumma23 commented on code in PR #17596:
URL: https://github.com/apache/druid/pull/17596#discussion_r1929264016
##########
extensions-contrib/prometheus-emitter/src/test/java/org/apache/druid/emitter/prometheus/PrometheusEmitterConfigTest.java:
##########
@@ -48,4 +48,82 @@ public void testEmitterConfigWithBadExtraLabels()
Assert.assertTrue(actualMessage.contains(expectedMessage));
}
+ @Test
+ public void testDefaultConstructor()
+ {
+ PrometheusEmitterConfig config = new PrometheusEmitterConfig(null, null,
null, null, null, false, false, null, null, null, null);
+ Assert.assertEquals(PrometheusEmitterConfig.Strategy.exporter,
config.getStrategy());
+ Assert.assertEquals("druid", config.getNamespace());
+ Assert.assertNull(config.getDimensionMapPath());
+ }
+
+ @Test
+ public void testExporterStrategy()
+ {
+ PrometheusEmitterConfig config = new
PrometheusEmitterConfig(PrometheusEmitterConfig.Strategy.exporter, "druid",
null, 8080, null, true, true, null, null, null, null);
+ Assert.assertEquals(PrometheusEmitterConfig.Strategy.exporter,
config.getStrategy());
+ Assert.assertEquals("druid", config.getNamespace());
+ Assert.assertEquals(8080, config.getPort());
+ Assert.assertTrue(config.isAddHostAsLabel());
+ Assert.assertTrue(config.isAddHostAsLabel());
+ }
+
+ @Test
+ public void testExporterStrategyWithoutPort()
+ {
+ Assert.assertThrows(IllegalArgumentException.class, () -> {
+ new PrometheusEmitterConfig(PrometheusEmitterConfig.Strategy.exporter,
null, null, null, null, false, false, null, null, null, null);
+ });
+ }
Review Comment:
Also combined these two tests into one, so that both ExporterStrategy and
PushGatewayStrategy will have one test each.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
