kgyrtkirk commented on PR #17623: URL: https://github.com/apache/druid/pull/17623#issuecomment-2618708422
I don't think `DataSource` is api - its not marked with the [annotations](https://github.com/apache/druid/blob/e36e187a632ef1b3784a1c0f8b8048d2101070db/processing/src/main/java/org/apache/druid/query/DataSource.java#L53) I haven't seen any implementations of it outside the core modules - in fact the current way things work; if someone would add a new datasource would have a pretty rough time running that on msq ; or having it work correctly in joins. The issues I've seen can't be fixed without altering the `Datasource` api; unless I cheat with proxies/etc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
