gianm commented on code in PR #16326:
URL: https://github.com/apache/druid/pull/16326#discussion_r1940491816
##########
processing/src/main/java/org/apache/druid/query/timeseries/TimeseriesQueryQueryToolChest.java:
##########
@@ -231,32 +232,17 @@ public Comparator<Result<TimeseriesResultValue>>
createResultComparator(Query<Re
return ResultGranularTimestampComparator.create(query.getGranularity(),
((TimeseriesQuery) query).isDescending());
}
- private Result<TimeseriesResultValue>
getNullTimeseriesResultValue(TimeseriesQuery query)
+ /**
+ * Returns a {@link TimeseriesResultValue} that corresponds to an empty-set
aggregation, which is used in situations
+ * where we want to return a single result representing "nothing was
aggregated".
+ */
+ public Result<TimeseriesResultValue>
getEmptyTimeseriesResultValue(TimeseriesQuery query)
Review Comment:
I made it package-private.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
